Skip to content

Feature/custom underline color #164

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 30, 2025
Merged

Feature/custom underline color #164

merged 1 commit into from
Oct 30, 2025

Conversation

@zeule
Copy link
Contributor

@zeule zeule commented Jul 26, 2024

image

@zeule zeule force-pushed the feature/custom-underline-color branch 2 times, most recently from 253b130 to d51e318 Compare October 27, 2025 14:02
@zeule
Copy link
Contributor Author

zeule commented Oct 27, 2025

@CJCombrink please consider this PR.

CJCombrink
CJCombrink reviewed Oct 27, 2025
View reviewed changes
src/spellcheckercoresettings.cpp Outdated
different = different | ( checkExternalFiles != other.checkExternalFiles );
different = different | ( projectsToIgnore != other.projectsToIgnore );
different = different | ( replaceAllFromRightClick != other.replaceAllFromRightClick );
different |= errorsColor != other.errorsColor;
Copy link
Owner

@CJCombrink CJCombrink Oct 27, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please stick with the pattern used by the other checks.

🤔 What is the minimum compiler version for Qt Creator at this time, can't this whole function be replaced with a default comparison operator yet?

Copy link
Contributor Author

@zeule zeule Oct 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Brought that in line with the existing checks.

@CJCombrink
Copy link
Owner

CJCombrink commented Oct 27, 2025

Thanks for this, it will be very useful to have.
I still want to test this, perhaps look at the option on the settings page, perhaps a more rounded button with a border and instead of "Error Color" it could read "Underline Color"?

@zeule zeule force-pushed the feature/custom-underline-color branch 2 times, most recently from 542c4f9 to decf970 Compare October 28, 2025 08:51
@zeule zeule force-pushed the feature/custom-underline-color branch from decf970 to 8d59166 Compare October 28, 2025 08:52
@zeule
Copy link
Contributor Author

zeule commented Oct 28, 2025

perhaps a more rounded button with a border

It's a Utils::QtColorButton instance, so I suppose this is how Qt guys want the color selection to look.

and instead of "Error Color" it could read "Underline Color"?

Done.

@CJCombrink CJCombrink merged commit 8d59166 into CJCombrink:main Oct 30, 2025
@CJCombrink
Copy link
Owner

CJCombrink commented Oct 30, 2025

Thanks you very much for this.
I did reduce the width a bit, hope you don't mind.

@zeule
Copy link
Contributor Author

zeule commented Nov 1, 2025

Thanks!

@zeule zeule deleted the feature/custom-underline-color branch November 1, 2025 10:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@CJCombrink CJCombrink CJCombrink left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@zeule @CJCombrink